grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Are BSD partitions not supported?


From: C. P. Ghost
Subject: Re: Are BSD partitions not supported?
Date: Sun, 23 May 2010 17:44:11 +0200

2010/5/23 Grégoire Sutre <address@hidden>:
> On 05/19/2010 09:20 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>
> [snip]
> -  delta = grub_partition_get_start (disk->partition);
> +      delta = grub_le_to_cpu32 (whole_disk_be.offset);
>
> As dicsussed on irc, this makes the delta completely dependent on the
> c: entry of the disklabel, which could be bogus.

(...)

> What we want here is to diverge from that code when the disklabel
> offsets are relative.  I believe that testing whether c: has a null
> offset gives the answer.  I changed Vladimir's second patch to do that.

With bsdlabel_v3.diff, and the image I've posted here, I get dropped
into grub_rescue. This breaks Vladimir's second patch on FreeBSD. :-(

-cpghost.

-- 
Cordula's Web. http://www.cordula.ws/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]