[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] File name transformations (split into 7 diffs)

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] File name transformations (split into 7 diffs)
Date: Mon, 07 Jun 2010 23:16:51 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100515 Icedove/3.0.4

Regarding file-name-transformations_1.diff:
address@hidden:~$ /usr/local/bin/grub-mkfont --help
Usage: /usr/local/bin/grub-mkfont [OPTIONS] FONT_FILES

So I would prefer not to use basename for uniformity. Otherwise patch 1 is ok.

On 06/04/2010 01:42 AM, Grégoire Sutre wrote:

This is the same patch as I sent before, but this time split into 7
diffs (which must be successively applied in order) and with a cleaner
changelog.  I hope that this will facilitate the review.

This version does not include the --root-directory addition to
grub-mkconfig, as this is quite orthognal to the goal of the patch (file
name transformation).

I welcome your comments,


--- mostly taken from my previous message ------------------------------

The attached patch fixes problems with file name transformations, which
are partly broken in trunk.  With this patch, several installations of
grub can coexist with no conflict (at least they should), sharing
however the same configuration directory (etc/grub.d).

For instance:

./configure --program-transform-name=s,grub,aaa,

will install bin/aaa-*, sbin/aaa-*, etc. The default grub directory will
be /boot/aaa, modules will be installed there and grub-mkconfig will
look for them there.

The main changes in the patch are:

- configure defines three new variables, accounting for transformations:
  . pkgdatadir       (${datadir}/grub)
  . pkglibrootdir    (${libdir}/grub)
  . defaultbootdir   (/boot/grub, or /grub if OS is NetBSD or OpenBSD)

- these variables are used in Makefile and in util/... scripts

- output of --help and of --version in scripts uses `basename $0` and
  the same format as the one in binaries.

- in Makefile, the help2man, .info, and .mo rules also account for
  file name transformations.

- grub-mkconfig exports GRUB_DIR, which is used by grub-mkconfig_lib
  and by 00_header.


_______________________________________________ Grub-devel mailing list address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]