[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug in multiboot_mbi2.c
From: |
Colin Watson |
Subject: |
Re: Bug in multiboot_mbi2.c |
Date: |
Wed, 23 Jun 2010 09:24:30 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jun 21, 2010 at 07:22:00PM -0700, Seth Goldberg wrote:
> The code that constructs the framebuffer info has a nasty bug where the
> field position and mask size for red are set to the GREEN values:
>
> tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
> tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
> --> tag->framebuffer_red_field_position = mode_info.green_field_pos;
> --> tag->framebuffer_red_mask_size = mode_info.green_mask_size;
> tag->framebuffer_green_field_position = mode_info.green_field_pos;
> tag->framebuffer_green_mask_size = mode_info.green_mask_size;
> tag->framebuffer_blue_field_position = mode_info.blue_field_pos;
> tag->framebuffer_blue_mask_size = mode_info.blue_mask_size;
Fixed, thanks (as well as the redundant assignment you mentioned in a
follow-up). I fixed the same bug in loader/i386/multiboot_mbi.c too.
--
Colin Watson address@hidden