[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gfxterm/pager regression
From: |
Colin Watson |
Subject: |
Re: gfxterm/pager regression |
Date: |
Tue, 6 Jul 2010 19:26:37 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jul 06, 2010 at 02:06:47AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 07/05/2010 02:47 PM, Colin Watson wrote:
> > gfxterm is behaving very oddly for me with 'set pager=1' right now; the
> > --MORE-- prompt appears after only a few lines of text have been output.
> > It looks rather as if it is counting the number of output characters as
> > if they were the number of output lines. This doesn't happen when the
> > terminal output is an ordinary VGA console.
> >
> > Looking at normal/term.c:put_glyphs_terminal, it seems that it
> > increments state->num_lines after every glyph. This seems pretty odd.
> > Doesn't it need to do something a bit smarter than that? Vladimir, is
> > this a regression from your bidi branch merge?
>
> Looks this way. Please test attached patch.
This looks good and works much better. Thanks!
--
Colin Watson address@hidden