[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Need --divide flag for assembly of startup.S on some platforms

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: Need --divide flag for assembly of startup.S on some platforms
Date: Thu, 02 Dec 2010 22:42:10 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101030 Icedove/3.0.10

On 12/02/2010 10:29 PM, Colin Watson wrote:
> On Thu, Dec 02, 2010 at 01:15:10PM -0800, Seth Goldberg wrote:
>>   When assembling grub-core/kern/i386/pc/startup.S, gas on some platforms 
>> chokes on this line:
>>        movl    $((LOCAL(bypass_table_end) - LOCAL(bypass_table)) / 2), %ecx
>>  Because on non i386-linux targets, '/' is used as a comment delimiter 
>> for compatibility purposes.  This can be overridden with the --divide 
>> switch.
>>   Since the default for gas on these platforms is to use he division 
>> operator as a comment delimiter, the "-Wa,--divide" flags need to be 
>> passed on the gcc command line when assembling such files.
> Can we just use >> 1 instead?
This was my first thought. But for maintenance reasons it would be
better if we can make all platforms behave the same. Can we just
inconditionally add -Wa,--divide to TARGET_ASFLAGS ?

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]