[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Horizontal boot menu

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: Horizontal boot menu
Date: Tue, 31 May 2011 19:56:24 -0400
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110402 Iceowl/1.0b2 Icedove/3.1.9

On 10.04.2011 15:09, Endres Puschner wrote:
> Hi, grub-developers,
> I implemented a complete horizontal extension to the boot menu and
> some other little features and fixes for extending the gfxmenu boot menu.
Haven't looked through whole of it but it has 2 serious problems:
1) Environment variable is used where it's not to be used by scripts. In
such cases a C variable is more appropriate.
2) It doesn't handle the multiterminal case correctly. Even if the menu
on local console is vertical, the menu on e.g. serial will remain
vertical and with your code the remote operator will have very confusing
key settings. It would be nicer if one could have the same key bindings
for both vertical and horizontal menu. The operation of left/right keys
can be an alias to up/down. In case it's justifiably impractical you
would need a new terminal flag which marks a local console. It should be
set on *_keyboard and console (all platform variants). This could then
also be used for some things Colin proposed some time ago.
> I would just describe my added theme parameters for the boot_menu
> control:
>   - item_width: Optionally specifying a width for each item in
> horizontal lists, but could also be implemented to work with vertical
> lists.
>   - item_icon_padding: Padding between icon and box or between icon
> and other item if there is no item_box.
>   - horizontal: boolean, defining this boot_list as horizontal.
>   - item_pixmap_style: like selected_item_pixmap_style but for non
> selected entries.
>   - item_pixmap_icon_only: boolean, selected and unselected pixmaps
> are only shown around the icons and not around the whole item.
> The scrollbars must be manually turned around to be in horizontal
> mode, I have uploaded a demo theme as an example:
> I fixed a bug in the icon-section. The first group in any menuentry
> was skipped while looking for icons before, so only icons for the
> second class would be searched.
> The normal menu is also modified as I wanted to allow to use
> right/left keys while navigating through the menu while it is
> horizontal. At menu_init, a new environment variable (orientation) can
> be set by the used menu module to horizontal for obvious reasons.
> Best regards,
>    Endres
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]