[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Support for different hotkey action than execute

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: Support for different hotkey action than execute
Date: Mon, 05 Mar 2012 02:37:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0

On 27.02.2012 00:08, Andreas Born wrote:
Attached patch introduces a new environment variable hotkey_action. It can be set to select or execute, whereas the latter is the default. So the default behaviour doesn't change. With select set instead a menu entry is just selected and not executed/booted on hotkey press.

This is for example useful for long menus to directly jump to some initial and afterwards select the desired entry without going through the whole menu. One still has to explicitly mark the menu entry to jump to with the hotkey attribute. This patch only allows to change the action to take on hotkey press.

Not much code and most is inspired from grub_menu_get_timeout. Applies and works with r3991.

    Add support to the menu for changing the action on hotkey press:
    execute (default), select

    * grub-core/normal/menu.c (DEFAULT_HOTKEY_ACTION): New define.
This is a global change (affecting all menuentries) for a local goal (have a jump hotkey for a menuentry). This has a drawback of making simultaneous inclusion of two files with different behaviour problematic. This should be implemented as a separate --jump-hotkey with additional benefit of allowing both hotkey and jump hotkey at the same time.
    (run_menu): Handle hotkey_action.
    (grub_menu_get_hotkey_action): New function.
    * include/grub/menu.h (grub_menu_get_hotkey_action): New prototype.
    (grub_hotkey_action_type_t): New enum.

Grub-devel mailing list

Vladimir 'φ-coder/phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]