[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bug fix for bootp

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] bug fix for bootp
Date: Tue, 01 May 2012 15:20:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3

On 29.04.2012 20:59, Bean wrote:
> 2012/4/30 Bean <address@hidden>:
>> 2012/4/30 Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>:
>>> On 29.04.2012 20:26, Bean wrote:
>>>> Hi,
>>>> It should be ok, since it's inside    FOR_NET_NETWORK_LEVEL_INTERFACES
>>>> (inf) loop and compare inf->hwaddress.mac to the current dhcp response
>>>> packet.
>>> It's not. You return even if packet didn't match.
>> Hi,
>> Oh i see, i forget about the return a few lines beyond.
> Hi,
> oh, there seems to be a missing grub_netbuff_free here as well, pls
> check if this is ok.
The patch is still incorrect. Namely the problem is with netbuff_pull
being called in every loop. I've committed a fixed version.
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]