grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove CPPFLAGS_XEN


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] Remove CPPFLAGS_XEN
Date: Mon, 11 May 2015 13:33:03 +0200

GRUB is built with -nostd*. So when we want headers from /usr/include we can't omit including them

On May 11, 2015 1:30 PM, "Olaf Hering" <address@hidden> wrote:
On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:

> What is the problem you're trying to solve? We shouldn't require user to pass
> additional parameters for common cases of we can avoid it

My xen headers are in /odd/path, so I first tried
env CPPFLAGS_XEN=/odd/path/include ./configure && make
This failed because CPPFLAGS_XEN is a private make variable. Later I
looked at ./configure --help and noticed the CPPFLAGS variable, wich is
aoppearently the prefered way to specify them.
And the common case is maybe that /usr/include already has the xen
headers, in which case CPPFLAGS_XEN is not needed. I assume the initial
change should have done what my patch does.

Olaf

_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]