Re: [PATCH] Parse commandline in grub-xen

[Andrei Borzenkov]

В Mon, 11 May 2015 13:51:48 +0200
Olaf Hering <address@hidden> пишет:

> On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
> 
> > 
> > On May 11, 2015 1:23 PM, "Olaf Hering" <address@hidden> wrote:
> > >
> > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
> > >
> > > > Do you really own all those installs to be able to speak on behalf of 
> > > > all
> > of
> > > > them?
> > >
> > > Since there is zero upstream support for anything regarding grub xen
> > > distros are forced to provide their own grub-xen binary for dom0. This
> > > includes at least some script to do something useful within the very
> > > first grub-xen. So in this sense its up to whoever creates such dom0
> > > binary to handle variables as needed, and document the implemented
> > > features.
> > >
> > And your point is?
> 
> That this patch gets in as is?
> 
> How do you envison a way to select a boot device, or set debug=all or
> whatever a script may interpret?

Either by allowing ${grub.arg.XXX} (not sure if current grammar accepts
it) or by adding getarg command, something like

getarg --name debug --set debug

You do not control what arguments grub gets - end use (admin) controls
it. You cannot force end user to actually strictly comply with what you
expect. As example, grub.cfg you recently submitted has

if [ -n "hddev" ]

without initializing it first. So administrator setting this variable
will unintentionally change behavior of script.