Re: [PATCH] Parse commandline in grub-xen

[Vladimir 'phcoder' Serbinenko]

On May 11, 2015 8:46 PM, "Andrei Borzenkov" <address@hidden> wrote:
>
> В Mon, 11 May 2015 19:14:14 +0200
> "Vladimir 'phcoder' Serbinenko" <address@hidden> пишет:
>
> > On May 11, 2015 6:52 PM, "Andrei Borzenkov" <address@hidden> wrote:
> > >
> > > В Mon, 11 May 2015 14:55:34 +0200
> > > "Vladimir 'phcoder' Serbinenko" <address@hidden> пишет:
> > >
> > > > On May 11, 2015 2:04 PM, "Andrei Borzenkov" <address@hidden> wrote:
> > > > >
> > > > > В Mon, 11 May 2015 13:51:48 +0200
> > > > > Olaf Hering <address@hidden> пишет:
> > > > >
> > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
> > > > > >
> > > > > > >
> > > > > > > On May 11, 2015 1:23 PM, "Olaf Hering" <address@hidden> wrote:
> > > > > > > >
> > > > > > > > On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:
> > > > > > > >
> > > > > > > > > Do you really own all those installs to be able to speak on
> > > > behalf of all
> > > > > > > of
> > > > > > > > > them?
> > > > > > > >
> > > > > > > > Since there is zero upstream support for anything regarding
> > grub xen
> > > > > > > > distros are forced to provide their own grub-xen binary for
> > dom0.
> > > > This
> > > > > > > > includes at least some script to do something useful within the
> > very
> > > > > > > > first grub-xen. So in this sense its up to whoever creates such
> > dom0
> > > > > > > > binary to handle variables as needed, and document the
> > implemented
> > > > > > > > features.
> > > > > > > >
> > > > > > > And your point is?
> > > > > >
> > > > > > That this patch gets in as is?
> > > > > >
> > > > > > How do you envison a way to select a boot device, or set debug=all
> > or
> > > > > > whatever a script may interpret?
> > > > >
> > > > > Either by allowing ${grub.arg.XXX} (not sure if current grammar
> > accepts
> > > > > it) or by adding getarg command, something like
> > > > >
> > > > I prefer the former. But probably fwarg. Would be a better prefix. This
> > way
> > > > one can do:
> > > > extra="grub.root=xvda1"
> > > > And then get it as fwarg.grub.root whereas root for Linux would be
> > > > fwarg.root and thus avoiding any conflict
> > >
> > > Using it as variable name means change to parser with possible side
> > > effects; also it means it will go into core for every platform, even if
> > > platform itself does not support such variable passing, increasing its
> > > size.
> > We can link it in only for the affected platforms and call from
> > grub-machine-init. Also we don't need the full parser
>
> Having different syntax for different platforms is really no-go.
>
Agreed. I was just referring to the fact that the common syntax can be simple one and that we can put those functions in separate file and link only in select platforms
> > >Having it as external command does not require any core changes,
> > > will be used only when needed and could be modeled after getopt e.g.
> > > allowing loop over arguments.
> > >
> > > > > getarg --name debug --set debug
> > > > >
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel