Re: [PATCH v1] Support DHCPv6 and UEFI IPv6 PXE

[Michael Chang]

On Fri, May 15, 2015 at 09:40:26AM +0300, Andrei Borzenkov wrote:
> В Tue, 12 May 2015 16:49:47 +0800
> Michael Chang <address@hidden> пишет:
> 
> > This patch set tries to make support of configuring IPv6 network interface
> > through the DHCPv6 protocol. A new command, net_bootp6, is therefore 
> > introduced
> > to serve the purpose. You can think it as DHCPv6/IPv6 version of the 
> > existing
> > net_bootp command.
> > 
> 
> Note that spec actually suggests (requires?) that DHCPv6 transaction is
> triggered by receiving Router Advertisement with M/O bits set.

I know that. But UEFI IPv6 PXE booting just works without it. We can
still add it in the future if it is really mandatory. 

> 
> > In addition to that, the UEFI IPv6 PXE support can be easily done by sharing
> > the same routine with net_bootp6 to parse DHCPv6 Reply packet cached in the
> > firmware.
> > 
> 
> Looking in EFI spec I do not see it explaining what content this
> dhcp_ack packet has for IPv6. I mean, DHCPv6 has neither Discover not
> Acknowledge, and full DHCPv6 transaction requires *two* packets - one
> for getting address and one for getting other options (DNS/boot
> server). Let's see how it works in real world :)

Yes, I also noticed the problem. But In real world, it has been tested
for a while, as that's the same with how elilo handles it. That is
treating dhcp_ack packet as a single DHCPv6 reply packet and parse the
options in it.

Thanks,
Michael

> 
> > changes in v1:
> > - Added upper boundary check in find_dhcpv6_option
> > - Fix memory leak and freeing NULL pointer
> > - Improved error message logging to not get lost
> > - Use grub_cpu_to_be16_compile_time for endianess conversion when 
> > appropriate
> > - Removed grub_dhcpv6_dns_servers structure and use 16 bytes blocks
> > - Avoud magic numbers and use more descriptive sizeof when populating 
> > netbuff
> > - Move include/grub/efi/api.h to UEFI IPv6 PXE support patch
> > - Document the net_bootp6 command
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/grub-devel
>