[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ofdisk: allocate space for vscsi table
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] ofdisk: allocate space for vscsi table |
|
Date: |
Mon, 9 Nov 2015 11:46:33 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 |
On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote:
> + /* 64 entries should be enough */
> + table_size = sizeof (grub_uint64_t) * 64;
Can we do something better than assuming a particular upper limit? You
don't even pass this limit to the function in any way. You basically get
a buffer overflow. Should we perhaps pass the limit in nentries? Or do
something similar?
signature.asc
Description: OpenPGP digital signature