[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] efinet: check for broken firmware
From: |
Andrei Borzenkov |
Subject: |
Re: [PATCH] efinet: check for broken firmware |
Date: |
Fri, 13 Nov 2015 17:38:52 +0300 |
On Fri, Nov 13, 2015 at 5:30 PM, Josef Bacik <address@hidden> wrote:
>>> @@ -291,6 +286,9 @@ grub_efinet_findcards (void)
>>> 0, &num_handles);
>>> if (! handles)
>>> return;
>>> +
>>> + attributes = grub_snp_attributes();
>>> +
>>> for (handle = handles; num_handles--; handle++)
>>> {
>>> grub_efi_simple_network_t *net;
>>> @@ -319,8 +317,7 @@ grub_efinet_findcards (void)
>>> && GRUB_EFI_DEVICE_PATH_SUBTYPE (parent) ==
>>> GRUB_EFI_MAC_ADDRESS_DEVICE_PATH_SUBTYPE)
>>> continue;
>>>
>>> - net = grub_efi_open_protocol (*handle, &net_io_guid,
>>> - GRUB_EFI_OPEN_PROTOCOL_GET_PROTOCOL);
>>> + net = grub_efi_open_protocol (*handle, &net_io_guid, attributes);
>>
>>
>> No, we cannot open exclusively here, it will destroy autocnfiguration
>> information we need later. You need to add conditional in open_card.
>
>
> The autoconfig stuff still works later for me but I can change it back.
Thaty would mean your firmware probably is SNP based and not MNP
based. But it will definitely break autoconfig for others - was there,
done that :)
- Re: [PATCH] efinet: check for broken firmware, (continued)
- Re: [PATCH] efinet: check for broken firmware, Josef Bacik, 2015/11/13
- Re: [PATCH] efinet: check for broken firmware, Andrei Borzenkov, 2015/11/13
- Re: [PATCH] efinet: check for broken firmware, Josef Bacik, 2015/11/13
- Re: [PATCH] efinet: check for broken firmware, Andrei Borzenkov, 2015/11/14
- Re: [PATCH] efinet: check for broken firmware, Vladimir 'phcoder' Serbinenko, 2015/11/14
- Re: [PATCH] efinet: check for broken firmware, Josef Bacik, 2015/11/16
- Re: [PATCH] efinet: check for broken firmware,
Andrei Borzenkov <=
- Re: [PATCH] efinet: check for broken firmware, Josef Bacik, 2015/11/13