grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ahci: Increase time-out from 10 s to 32 s


From: Daniel Kiper
Subject: Re: [PATCH] ahci: Increase time-out from 10 s to 32 s
Date: Tue, 4 Sep 2018 14:30:02 +0200
User-agent: Mutt/1.3.28i

On Thu, Aug 09, 2018 at 06:10:51PM +0200, Paul Menzel wrote:
> Date: Thu, 9 Aug 2018 07:27:35 +0200
>
> Currently, the GRUB payload for coreboot does not detect the Western
> Digital hard disk WDC WD20EARS-60M AB51 connected to the ASRock E350M1,
> as that takes over ten seconds to spin up.
>
> ```
> disk/ahci.c:533: port 0, err: 0
> disk/ahci.c:539: port 0, err: 0
> disk/ahci.c:543: port 0, err: 0
> disk/ahci.c:549: port 0, offset: 120, tfd:80, CMD: 6016
> disk/ahci.c:552: port 0, err: 0
> disk/ahci.c:563: port 0, offset: 120, tfd:80, CMD: 6016
> disk/ahci.c:566: port: 0, err: 0
> disk/ahci.c:593: port 0 is busy
> disk/ahci.c:621: cleaning up failed devs
> ```
>
> GRUB detects the drive, when either unloading the module *ahci*, and
> then loading it again, or when doing a warm reset.
>
> As the ten second time-out is too short, increase it to 32 seconds,
> used by SeaBIOS. which detects the drive successfully.
>
> The AHCI driver in libpayload uses 30 seconds, and that time-out was
> added in commit 354066e1 (libpayload: ahci: Increase timeout for
> signature reading) with the description below.
>
> > We can't read the drives signature before it's ready, i.e. spun up.
> > So set the timeout to the standard 30s. Also put a notice on the
> > console, so the user knows why the signature reading failed.
>
> Signed-off-by: Paul Menzel <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]