Re: [PATCH] osdep/linux: convert partition start to disk sector length.

[Daniel Kiper]

On Mon, Jul 23, 2018 at 08:52:50AM +0200, Mihai Moldovan wrote:
> When reading data off a disk, sector values are based on the disk sector
> length.
>
> Within grub_util_fd_open_device(), the start of the partition was taken
> directly from grub's partition information structure, which uses the
> internal sector length (currently 512b), but never transformed to the
> disk's sector length.
>
> Subsequent calculations were all wrong for devices that have a diverging
> sector length and the functions eventually skipped to the wrong stream
> location, reading invalid data.

Lack of SOB... May I ask you to add it? Otherwise LGTM.

Daniel