Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

[Daniel Kiper]

On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote:
> On Thu, 6 Sep 2018, 17:03 Paul Menzel, <address@hidden> wrote:
>
> > Date: Thu, 6 Sep 2018 15:15:45 +0200
> >
> > If executing `efibootmgr` fails, for example, because the system is
> > booted in legacy mode, but with a mounted EFI System Partition, the
> > error message mentions *efibootmgr*. To make it easier for users to work
> > around that problem by skipping running `efibootmgr`, add the word to
> > the description of the switch *no-nvram*, which skips the efibootmgr
> > execution.
> >
> > Signed-off-by: Paul Menzel <address@hidden>
> > ---
> > v2: Add Signed-off-by line
> >
> >  util/grub-install.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/util/grub-install.c b/util/grub-install.c
> > index a44858198..335662a58 100644
> > --- a/util/grub-install.c
> > +++ b/util/grub-install.c
> > @@ -276,7 +276,7 @@ static struct argp_option options[] = {
> >     N_("disk module to use (biosdisk or native). "
> >        "This option is only available on BIOS target."), 2},
> >    {"no-nvram", OPTION_NO_NVRAM, 0, 0,
> > -   N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
> > +   N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM
> > variables. "
> >        "This option is only available on EFI and IEEE1275 targets."), 2},
> >
> In case of ieee1275 this has nothing to do with efibootmgr

Paul, are you going to repost the patch with relevant change in the code
and commit message or should I fix it just before push?

Daniel