[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 3 readline bugs: source positions, readline-options, endless loop on
Re: 3 readline bugs: source positions, readline-options, endless loop on error
Fri, 26 Jan 2001 00:24:12 +0100 (MET)
On Thu, 25 Jan 2001, Martin Grabmueller wrote:
> I started to work on the patch, but I got pretty confused. Maybe this
> is due to my understanding of the term `memoization'.
> I take the discussion to guile-devel, so that someone may enlighten me.
> It seems that `memoization' is used for two different concepts:
> - Rewriting code expressions to a more efficient internal
> representation, like syntax expressions, glocs, ilocs, etc.
> - For remembering the positions of source expressions.
Actually, it's just the first (AFAIK). But, the fact that code is
transformed into an internal representation makes the whole source
properties thing more difficult, because you'd like to report errors on
the _original_ code...
> With added tests, I got the following patch, but I am not sure whether
> it really is The Right Thing. It enables error positions for readline
> and string ports, so it is at least A Useful Thing:
Actually, I think it is exactly The Right Thing. Thanks a lot.
It is still an interesting question, however, whether we should rather
store the port instead of a filename... I have added a FIXME comment to
your patch that will at least keep that idea noted down...
It will be in cvs in a short time. Thank you very much for your help.