[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH for guile-readline/

From: Richard Todd
Subject: Re: PATCH for guile-readline/
Date: Wed, 14 Jan 2004 19:17:18 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

Kevin Ryde wrote:
Richard Todd <address@hidden> writes:

If you don't like this method and can find a better way, please do so,

How about

        ln -s $(srcdir)/readline.scm ice-9/readline.scm

$(srcdir) is right for both in-place and separate builds.

Yeah, I tried that, but for an in-tree build, $(srcdir) == ".". On the two systems I tried it on, that command leads to:
  readline.scm -> ./readline.scm  ( a link ot itself!)

That's why I said it's trickier than it sounds! :)

+             (cd ice-9 && $(LN_S) ../$<)  \
+        else \
+             (cd ice-9 && $(LN_S) $<) \

Alas, $< is not portable in ordinary rules (see the autoconf manual).

Thanks for pointing this out.  I'll remember that.

For what it's worth, I liked merging readline into guile-core the best, but if the license issue is too much to overcome, then I don't see much difference in quality between the 'link' approaches and the 'new directory' approach. If there were going to be lots more ice-9/xx.scm files for readline, then the new directory would definitlely by cleaner.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]