[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add `scm_c_symbol_length ()'
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add `scm_c_symbol_length ()' |
Date: |
Sat, 05 Jul 2008 20:26:09 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) |
Hi,
"Neil Jerram" <address@hidden> writes:
> 2008/7/1 Ludovic Courtès <address@hidden>:
>> Andy pointed out that `scm_i_symbol_length ()' is actually used in
>> places where struct layout strings are manipulated, for instance, so
>> making it internal can be harmful.
>>
>> The attached patch renames it to `scm_c_symbol_length ()' and documents
>> it. I'll apply it if nobody disagrees in the next few days.
>
> Looks good to me.
Thanks. I took a slightly different route, which is to keep both the
`scm_c_' and `scm_i_' functions:
http://git.sv.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=071bb6a84061dd8fba278219797fd376b0a54e10
It allows internal code to skip type-checking. The same is done with
`scm_i_string_length ()'.
Thanks,
Ludovic.