[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Locks and threads
From: |
Ludovic Courtès |
Subject: |
Re: Locks and threads |
Date: |
Wed, 25 Mar 2009 23:08:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) |
Hi Neil,
Neil Jerram <address@hidden> writes:
> Neil Jerram <address@hidden> writes:
>> Subject: [PATCH] Avoid throw from critical section, given invalid sigaction
>> call
>>
>> * libguile/scmsigs.c (scm_sigaction_for_thread): Exit critical section
>> before raising out-of-range error.
>>
>> * test-suite/Makefile.am (SCM_TESTS): Add signals.test.
>>
>> * test-suite/tests/signals.test: New file.
>
> I've committed this now too. (Also to 1.8.x. I'll come back later to
> look at which of all these lock fixes are needed in master.)
Perfect!
This one can go in `master' too, I think.
Neil Jerram <address@hidden> writes:
> Neil Jerram <address@hidden> writes:
>
>> I've been running Linas's define-race test program, and hitting the
>> `throw from within critical section' quite a lot.
>>
>> We've already discussed this a couple of times:
>> http://www.mail-archive.com/address@hidden/msg04613.html
>> http://www.mail-archive.com/address@hidden/msg03016.html
>>
>> Andy proposed just removing the check for 1.8.x, but I would prefer to
>> keep it if possible, as I think there probably still are genuine
>> problems where the check could help. What about the patch below?
>
> I don't believe anyone commented on this, but I've committed it now to
> 1.8.x. In case of any concerns, please let me know.
Sorry for not commenting earlier. This looks good to me. I suppose it
can't hurt in `master'; the future of critical sections is uncertain,
though.
Thanks!
Ludo'.
- Re: Locks and threads, (continued)
- Re: Locks and threads, Linas Vepstas, 2009/03/05
- Re: Locks and threads, Neil Jerram, 2009/03/05
- Re: Locks and threads, Linas Vepstas, 2009/03/05
- Re: Locks and threads, Andy Wingo, 2009/03/06
- Re: Locks and threads, Linas Vepstas, 2009/03/06
- Re: Locks and threads, Ludovic Courtès, 2009/03/06
- Re: Locks and threads, Neil Jerram, 2009/03/08
- Re: Locks and threads, Neil Jerram, 2009/03/25
- Re: Locks and threads,
Ludovic Courtès <=
Re: Locks and threads, Ludovic Courtès, 2009/03/05
Re: Locks and threads, Neil Jerram, 2009/03/10
- Re: Locks and threads, Neil Jerram, 2009/03/11
- Re: Locks and threads, Neil Jerram, 2009/03/11
- Re: Locks and threads, Linas Vepstas, 2009/03/11
- Re: Locks and threads, Clinton Ebadi, 2009/03/11
- Re: Locks and threads, Neil Jerram, 2009/03/25
- Re: Locks and threads, Linas Vepstas, 2009/03/25
Re: Locks and threads, Andy Wingo, 2009/03/12
Re: Locks and threads, Neil Jerram, 2009/03/13