Re: [PATCH] Unicode general categories

[Mike Gran]

> Hi all,
> 
> Find attached a patch that adds support for finding out the Unicode
> general category [0] for a character, including documentation and unit
> tests.  The API is pretty much the same as the one described in R6RS
> Standard Libraries 1.1 [1].  I'll push if no one objects.

Hi Julian-

Cool.  I have two very minor and pedantic suggestions.  You say that 
it will return a "one- or two-letter name".  I'm pretty sure that
this code will always return a two-letter name and not the one-letter
general category.  

Also, the output of SCM_CHAR is effectively a 32-bit signed int and the 
uc_general_category takes effectively a 32-bit unsigned int, so perhaps the
cast to (int) should be left out or be libunistring's (ucs4_t) instead.
But, of course, the code works fine as it is.

Thanks,

Mike Gran