[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Universally-unique gensyms

From: Andy Wingo
Subject: Re: [PATCH] Universally-unique gensyms
Date: Tue, 17 Jan 2012 14:57:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Hi Mark,


On Tue 17 Jan 2012 14:27, Mark H Weaver <address@hidden> writes:

> This patch makes our gensyms universally-unique.  Comments welcome.

I think the lazy initialization needs to happen within the lock.  Also
it would be nice to factor out the initialization of the random seed
would be a nice helper to have in random.[ch].  You probably don't need
to have a flag to support /dev/random (rather than urandom), because
after all it's only seeding a PRNG (and not a cryptographically safe
one, at that).

Otherwise looks great to me!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]