guile-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Per-port read options, reader directives, SRFI-105


From: David A. Wheeler
Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105
Date: Wed, 24 Oct 2012 17:52:13 -0400 (EDT)

Mark H Weaver:
> Here's an improved version of the patch set, incorporating Ludovic's
> suggestions and rebased on the current stable-2.0 branch.

I haven't had a chance to review the code in depth, but I find it *very* 
encouraging that this patch includes a nice long test suite for SRFI-105.  In 
particular, I appreciate that this patch includes a test for "{f{n - 1}(x)}".  
That one is important, because older versions of the reference implementation 
got that wrong (the spec requires left-to-right, but the code in that case 
accidentally did right-to-left).  So that's a case particularly worth checking 
(and it does).

--- David A. Wheeler



reply via email to

[Prev in Thread] Current Thread [Next in Thread]