Re: GNU Guile 2.1.6 released (beta) [numbers.c]

[Matt Wette]

On Jan 20, 2017, at 11:01 AM, Matt Wette <address@hidden> wrote:

On Jan 19, 2017, at 7:01 PM, Matt Wette <address@hidden> wrote:

On Jan 18, 2017, at 6:26 PM, Andy Wingo <address@hidden> wrote:

We are pleased to announce GNU Guile release 2.1.6.

Guile 2.1.6 is the sixth pre-release in what will eventually become the
2.2 release series.  We encourage you to test this release and provide
feedback to address@hidden.

Saw this one last round.  Mac OS, now gcc-6.3.0:

;;; ("address@hidden" 1.0 -0.0)

FAIL: numbers.test: string->number: valid complex number strings

I am going to see if I can generate the assembly.

Short story: scm_c_make_polar is broken for the Mac.  Guile needs to decide if it want to use __sincos() on Mac, or suppress optimization, or ...

a patch, with which make check passes all tests on macOS 10.12.2, aka Sierra:

--- libguile/numbers.c.orig     2017-01-19 16:57:30.000000000 -0800

+++ libguile/numbers.c  2017-01-19 20:20:58.000000000 -0800

@@ -9099,6 +9099,9 @@

 #undef FUNC_NAME

 

 SCM

+#if defined(__APPLE__) && defined(__GNUC__)

+__attribute__((optimize("O0")))

+#endif

 scm_c_make_polar (double mag, double ang)

 {

   double s, c;