[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk doe

From: Freja Nordsiek
Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7
Date: Wed, 1 Mar 2017 22:15:52 +0100

Thanks for the tip on how to properly reply to a bugreport. I will make sure I get that right next time.

By the way, I tested the method you used manually on 2.0.x today and it fixed the discrepancy with R6RS there too. Might consider patching that branch too. Hopefully no one has been depending on the non-truncating behavior.


On Mar 1, 2017 6:55 PM, "Andy Wingo" <address@hidden> wrote:
Heya Freja,

On Tue 21 Feb 2017 20:36, Freja Nordsiek <address@hidden> writes:

> Patch for bug #24816:

Apologies for not noticing this patch; I was working from the debbugs
interface and didn't see this.  In the future you can update a bug with
a patch by CC'ing address@hidden, e.g. address@hidden.

Your patch is pretty much exactly what I did, too :)  One thing I did
was require the port position to be within the bounds of the truncated
size; was a tough call but truncate-file on a file doesn't adjust the
position, so there's that.

Thank you again for the patch and sorry for missing it.  Looking forward
to future patches :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]