guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells


From: John Darrington
Subject: Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells
Date: Thu, 13 Feb 2014 09:07:20 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Feb 13, 2014 at 03:00:29AM -0500, Mark H Weaver wrote:
     This patch makes xterm honor $SHELL (or the shell in the user's password
     entry) even if it's not in /etc/shells.  WDYT?
     

It sounds like a good idea to me.  /etc/shells is supposed to be only a 
whitelist of
those shells which may be used for login.  Not an exhaustive list of shells 
which
may be used at all.

However, I'm wondering if we are forking too many upstream packages.  We should
only patch software in order to allow it to build/install.  If we want to change
the behaviour like here, that should be sent to upstream for their next release.

If they refuse the patch, then of course you can start your own weavershell 
fork...

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]