guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] union: Ensure that the output is always a directory


From: Ludovic Courtès
Subject: Re: [PATCH] union: Ensure that the output is always a directory
Date: Fri, 04 Apr 2014 00:10:01 +0200
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Mark H Weaver <address@hidden> skribis:

> From 6c8582bc41c8935b8e9d63146595e87d9b92fa95 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Thu, 3 Apr 2014 17:49:20 -0400
> Subject: [PATCH] union: Ensure that the output is always a directory.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Fixes the creation of single-package profiles, reported by Ludovic Courtès.
>
> * guix/build/union.scm (union-build): Add new internal procedure
>   'union-of-directories' that always creates a directory, containing the code
>   previously used only to merge multiple directories.  Call it from the
>   multiple-directory case in 'union' and from the top-level 'union-build'.

Looks good to me.

Can you run ‘make check TESTS=tests/guix-package.sh’, and push if it’s
OK?  (Actually that test was catching the problem.)

Thanks for the quick fix!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]