guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] gnu: Some cleanup based on lint checkers.


From: Andreas Enge
Subject: Re: [PATCH 5/5] gnu: Some cleanup based on lint checkers.
Date: Fri, 24 Oct 2014 18:05:37 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Oct 24, 2014 at 12:19:03AM -0500, Eric Bavier wrote:
> 2. Many descriptions begin with the package name in lowercase form,
> which triggers a warning about the description beginning with a
> lowercase letter.  In this patch I capitalised the package name if I
> could find a reference to the capital form on the package's home-page
> somewhere.  Many packages are quite insistent that the package always be
> referenced by the lowercase name, and I'm not sure how the description
> would be reworded, or whether it really needs to be.  We could add an
> exception to the description-starts-with-a-capital-letter rule for when
> the package name is the first word.

Personally I would capitalise; we are not bound by upstream wishes to use
incorrect language.

> 5. I didn't really want to begin looking at the synopses and
> descriptions in xorg.scm...

Actually, I filled most of them with a fixed synopsis and description that
is independent of the actual package. So if they do not pass the tests,
they should be simple to modify.

> Comments welcome.  Nitpicks especially, since much of this is already
> quite nitpicky. ;)

I would rather trust you with these clean-ups than go through all of the
changes myself... I think they fall under the "one may push simple changes"
provision anyway.

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]