Re: [PATCH 11/15] gnu: Add xfce4-settings.

[宋文武]

Mark H Weaver <address@hidden> writes:

> 宋文武 <address@hidden> writes:
>
>> * gnu/packages/xfce.scm (xfce4-settings): New variable.
>> ---
>>  gnu/packages/xfce.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
>> index 5f15594..c601852 100644
>> --- a/gnu/packages/xfce.scm
>> +++ b/gnu/packages/xfce.scm
>> @@ -310,3 +310,33 @@ your system in categories, so you can quickly find and 
>> launch them.")
>>       "Session manager for Xfce, it will restores your session on startup and
>>  allows you to shutdown the computer from Xfce.")
>>      (license gpl2+)))
>> +
>> +(define-public xfce4-sesttings
>
> The variable name above has a typo:
>   'xfce4-sesttings' ->
>   'xfce4-settings'.
Oh
>
>> +  (package
>> +    (name "xfce4-settings")
>> +    (version "4.10.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "http://archive.xfce.org/xfce/4.10/src/";
>> +                                  name "-" version ".tar.bz2"))
>
> Instead of putting "4.10" directly in the string above, how about this:
>
>     (uri (string-append "http://archive.xfce.org/xfce/";
>                         (version-major+minor version)
>                         "/src/" name "-" version ".tar.bz2"))
>
> This way, when the package is updated to a new version, there will be
> one less thing to change.  The same change could be made to many of your
> other xfce packages.
>
> 'version-major+minor' is in the (guix utils) module, so you'll need to
> add that to the import list.
Adjusted, thanks for review!
>
> Thanks for working on this!
>
>       Mark