guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: jack: propagate libuuid


From: Mark H Weaver
Subject: Re: [PATCH]: jack: propagate libuuid
Date: Tue, 17 Feb 2015 17:13:04 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Ricardo Wurmus <address@hidden> writes:

> Attached is a patch to move libuuid (provided by "util-linux") from the
> regular inputs of jack-1 to the propagated-inputs, as uuid.h is included
> from the JACK headers.
>
> The patch also removes "util-linux" from those inputs depending on
> jack-1.  I recompiled all of them and they still built as expected.
>
> ~~ Ricardo
>
> From 4729906c5156a7aeec917cbe1408d08a47369d59 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 17 Feb 2015 09:45:16 +0100
> Subject: [PATCH] gnu: jack: propagate input "util-linux"
>
> * gnu/packages/audio.scm (jack-1): Move input "util-linux" to
>   `propagated-inputs'.
> * gnu/packages/audio.scm (aubio, ardour, azr3, lash, patchage): Remove
>   "util-linux" from `inputs'.

Can you please split this up into two commits?  The first commit should
just move 'util-linux' into jack-1's propagated-inputs (with a comment
added in the source code explaining why its needed), and the second
commit should remove 'util-linux' from the inputs of the packages that
use jack-1.

Okay to push with these changes.

     Thanks!
       Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]