guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: gst-libav: Use system ffmpeg instead of bundled libav.


From: Mark H Weaver
Subject: Re: [PATCH] gnu: gst-libav: Use system ffmpeg instead of bundled libav.
Date: Tue, 14 Apr 2015 03:49:57 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

宋文武 <address@hidden> writes:

> * gnu/packages/gstreamer.scm (gst-libav)[arguments]: Remove #:phases.
>   Add #:configure-flags.
>   [navite-inputs]: Remove yasm.

Typo: s/navite/native/

>   [inputs]: Add ffmpeg.
> ---
>  gnu/packages/gstreamer.scm | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index 9758806..c3e9f1f 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -35,6 +35,7 @@
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pulseaudio)
> +  #:use-module (gnu packages video)
>    #:use-module (gnu packages xorg)
>    #:use-module (gnu packages xiph)
>    #:use-module (gnu packages pkg-config)
> @@ -262,19 +263,13 @@ developers consider to have good quality code and 
> correct functionality.")
>                  "1g7vg9amh3cc3nmc415h6g2rqxqi4wgwqi08hxfbpwq48ri64p30"))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:phases
> -       (modify-phases %standard-phases
> -         (add-before configure patch-/bin/sh
> -                     (lambda _
> -                       (substitute* "gst-libs/ext/libav/configure"
> -                         (("#! /bin/sh")
> -                          (string-append "#! "(which "sh")))))))))
> +     '(#:configure-flags '("--with-system-libav")))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
> -       ("python" ,python)
> -       ("yasm" ,yasm)))
> +       ("python" ,python)))
>      (inputs
>       `(("gst-plugins-base" ,gst-plugins-base)
> +       ("libav" ,ffmpeg)

How about ("ffmpeg" ,ffmpeg) instead?

>         ("orc" ,orc)
>         ("zlib" ,zlib)))
>      (home-page "http://gstreamer.freedesktop.org/";)

Okay to push with these changes.

    Thanks!
      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]