[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Add sra-tools.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 0/4] Add sra-tools. |
Date: |
Fri, 17 Apr 2015 14:42:40 +0200 |
Ludovic Courtès writes:
>> I had to remove libxml2 from the inputs to sra-tools, resulting in a
>> failure to build a couple of loader tools. The reason for this is that
>> I encountered linker problems like these:
>
> It looks like an upstream bug? And why is it being statically-linked
> anyway? It would be nice if they would default to dynamic linking,
> which is more efficient in terms of memory use, etc.
Indeed. I will file a bug report upstream.
>> + (synopsis "API for accessing Next Generation Sequencing data")
>
> I would put quotes around “Next Generation”. :-)
"Next-generation sequencing" is an actual term (although it sounds a
little silly). It refers to high-throughput sequencing technology.
See http://www.nature.com/subjects/next-generation-sequencing
>> + (synopsis "Java bindings for NGS SDK")
>> + (description
>> + (string-append (package-description ngs-sdk)
>> + "\n\nThis package contains the Java bindings."))))
>
> ‘description’ should be a string literal, otherwise xgettext won’t catch
> it, thereby preventing i18n.
>
> What I would do is just keep ‘description’ unchanged, or rewrite it.
> Keeping it unchanged is OK here since the synopsis makes it clear that
> these are Java bindings.
Okay, I'll just keep the inherited description then. I should note that
"python-wrapper" in python.scm also does not use a string literal.
~~ Ricardo