Re: [PATCH 01/10] gnu: base: Pass PATH_MAX TO sed and patch.

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> From 4eb7220772b5ddb916debb5577ebc8febbba55b4 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Sun, 3 May 2015 22:02:12 +0300
> Subject: [PATCH 01/10] gnu: base: Pass PATH_MAX TO sed and patch.
>
> * gnu/packages/base.scm (sed): Pass PATH_MAX to configure.
> * gnu/packages/base.scm (patch): Same.

[...]

> +        '(#:configure-flags '("CPPFLAGS=-DPATH_MAX=4096"))
>          `(#:phases (alist-cons-before
>                      'patch-source-shebangs 'patch-test-suite
>                      (lambda* (#:key inputs #:allow-other-keys)
> @@ -165,6 +165,8 @@ standard utility.")
>                 (base32
>                  "16d2r9kpivaak948mxzc0bai45mqfw73m113wrkmbffnalv1b5gx"))))
>     (build-system gnu-build-system)
> +   (arguments
> +    `(#:configure-flags '("CPPFLAGS=-DPATH_MAX=4096")))

Could you make sure ‘PATH_MAX’ is only defined on GNU/Hurd?

It might be best to just come up with a patch to the source.  For Guix,
an acceptable patch is just:

  #ifndef PATH_MAX
  # define PATH_MAX 4096
  #endif

added in the right place.

The ideal patch for upstream is something that uses malloc and similar
instead of fixed-length arrays.

Thanks,
Ludo’.