guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add hmmer


From: Ricardo Wurmus
Subject: Re: [PATCH] gnu: Add hmmer
Date: Sun, 21 Jun 2015 11:51:32 +0200

> +(define-public hmmer
> +  (package
> +    (name "hmmer")
> +    (version "3.1b2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://selab.janelia.org/software/hmmer3/3.1b2/hmmer-";
> +                 version ".tar.gz"))

This line is not aligned properly (probably because you are mixing tabs
and spaces).

The version number is also used in other parts of the URL.  How about
this instead (not tested):

  (uri (string-append
        "http://selab.janelia.org/software/hmmer";
        (version-prefix version 1) "/"
        version "/hmmer-" version ".tar.gz"))

The rest looks good to me.

~~ Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]