Re: [PATCH] Add skalibs, execline.

[韋嘉誠]

On Mon, Jun 29, 2015 at 11:36 AM, Claes Wallin (韋嘉誠)
<address@hidden> wrote:
> On Jun 28, 2015 10:38 PM, "Ludovic Courtès" <address@hidden> wrote:
>> "Claes Wallin (韋嘉誠)" <address@hidden> skribis:

>> Please start the .patch with a brief description of what it does, and
>> its upstream status (like “Upstream commit XYZ”, or “Submitted upstream
>> at http://...”.)
>
> Ok. I'll rename it too, as s6 turned out to need the same patch as
> well. It's not guix-specific, they actually don't compile from source.
> It's funny.

After talking with the author, an explicit --with-lib made the problem
go away, no patch necessary. Apparently GNU make has a special case
where it knows how to interpret -lmylib listed as a dependency.


>> > +       #:modules ((guix build utils)
>> > +                  (guix build gnu-build-system)
>> > +                  (ice-9 popen))
>>
>> Replace the first two with:
>>
>>   ,@%gnu-build-system-modules

... so this part is not even necessary any more.


>> Could you send updated patches?
>
> Will do!

And here they are. I improved (shortened) the wording for the
descriptions and fixed the formatting for the commit message.

0001-gnu-Add-skalibs.patch
Description: Binary data

0002-gnu-Add-execline.patch
Description: Binary data