Re: [PATCHES] Whip polkit into shape

[Ludovic Courtès]

Andy Wingo <address@hidden> skribis:

> On Tue 01 Sep 2015 13:53, Andy Wingo <address@hidden> writes:
>
>> Attached are three patches to polkit.  The first makes polkit use
>> elogind for seat management.  The second is based on a WIP patch from
>> Mark, and arranges for polkit to look in the system profile for rules
>> and actions.  The third adds a polkit service.  I've tested these by
>> running "pkaction" and "pkcheck", both with an embedded authentication
>> agent and with an external agent.  Kinda cool to see these work.
>> Unfortunately I haven't gotten user-mode "loginctl reboot" to work --
>> for some reason it doesn't end up spawning the authentication agent
>> correctly.  Oh well, future work.  Usually people will be running with a
>> authentication agent linked to their graphical session anyway.

OK, sounds like it’s getting there!  :-)

> From e409449f493da3a42b9f989c819d3290fe9a523a Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Tue, 18 Aug 2015 11:39:22 +0200
> Subject: [PATCH 3/7] gnu: polkit: Use elogind for seat management.
>
> * gnu/packages/polkit.scm (polkit): Depend on elogind.

OK.  Could you add a copyright line?

> From 11e1301553117f093642142bf50bb4462c87ba47 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Tue, 1 Sep 2015 13:30:31 +0200
> Subject: [PATCH 4/7] gnu: polkit: Look for rules in
>  /run/current-system/profile.
>
> * gnu/packages/polkit.scm (polkit): Configure to look for actions and
>   rules in the system profile.  Arrange to look for the setuid helper in
>   /run/setuid-programs.  Fix introspection installation.

I have a preference to the ‘dbus-service’ style, where we pass the exact
list of services to the service function, because it makes things
explicit and transparent.

But I’m fine with using this approach now and maybe revisiting it later.

> +;;; Copyright © 2015 Mark H Weaver <address@hidden>

Add yourself too?

> From ec20ffc9bdad2d467ec0f7e76f1b7f7a92580eff Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Tue, 18 Aug 2015 11:57:15 +0200
> Subject: [PATCH 5/7] gnu: Add polkit service.
>
> * gnu/services/desktop.scm (polkit-service): New function.
>   (%desktop-services): Add polkit service.

Could you add it to guix.texi?

Otherwise LGTM.

Thanks!

Ludo’.