guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/7] gnu: efl: Update to 1.15.1.


From: Efraim Flashner
Subject: Re: [PATCH 3/7] gnu: efl: Update to 1.15.1.
Date: Thu, 10 Sep 2015 20:52:59 +0300

On Thu, 10 Sep 2015 18:58:50 +0200
Mathieu Lirzin <address@hidden> wrote:

> Efraim Flashner <address@hidden> writes:
> 
> > * gnu/packages/enlightenment.scm (efl): Update to 1.15.1.
> >   Align package to 80 width columns.
>     ^^^
>     This is not necessary to notify indentation changes in commit
>     messages.
> 
> > ---
> >  gnu/packages/enlightenment.scm | 17 +++++++++--------
> >  1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/gnu/packages/enlightenment.scm
> > b/gnu/packages/enlightenment.scm index 2470d1e..6b1257a 100644
> > --- a/gnu/packages/enlightenment.scm
> > +++ b/gnu/packages/enlightenment.scm
> > @@ -51,14 +51,14 @@
> >  (define-public efl
> >    (package
> >      (name "efl")
> > -    (version "1.14.2")
> > +    (version "1.15.1")
> >      (source (origin
> > -              (method url-fetch)
> > -              (uri (string-append
> > -
> > "https://download.enlightenment.org/rel/libs/efl/efl-";
> > -                    version ".tar.xz"))
> > -              (sha256
> > -               (base32
> > "0kg51v63ljq1z4dj65aiyxaqhq54gkl4hx53ifwbci6ihammandr"))))
> > +             (method url-fetch)
> > +             (uri (string-append
> > +                   "https://download.enlightenment.org/rel/libs/efl/efl-";
> > +                   version ".tar.xz"))
> > +             (sha256
> > +              (base32
> > "1n2l2n09lys5dph9lrnsv5z3qbgzp7bi0vidal2fvy18hflbbvsn")))) (build-system
> > gnu-build-system) (native-inputs
> >       `(("pkg-config" ,pkg-config)))
> > @@ -127,7 +127,8 @@
> >  for Enlightenment.  Libraries covers data serialization, wide support for
> >  graphics rendering, UI layout and themes, interaction with OS, access to
> >  removable devices or support for multimedia.")
> > -    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) ;
> > different parts under different licenses
> > +    (license (list license:bsd-2 license:lgpl2.1 license:zlib)))) 
> > +                           ;;; different parts under different
> > licenses
> 
> There is a trailing white space here. ";;;" is not adapted for this type of
> comment I would suggest this
> 
>     ;; Different parts are under different licenses.
>     (license (list license:bsd-2 license:lgpl2.1 license:zlib))))
> 
> Can you send the updated patch?
> 
> --
> Mathieu Lirzin



-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: 0003-gnu-efl-Update-to-1.15.1.patch
Description: Text Data

Attachment: pgpy4mGgPlEd_.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]