Re: [PATCH 2/2] gnu: Add ruby-simplecov.

[Ricardo Wurmus]

Hi Pjotr,

> * gnu/packages/ruby.scm (ruby-simplecov): New variable.

[...]

> +  (propagated-inputs
> +    `(("ruby-docile" ,ruby-docile)
> +      ("ruby-json" ,ruby-json)))
> +    (arguments
> +     '(#:tests? #f)) ; needs github-markup, among others
> +  (synopsis "Code coverage for Ruby")

I find it very surprising to see only “docile” and “json” as inputs and
not “ruby-simplecov-html”.  According to
https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
dependency.

With my Ruby packages I’ve been closely following the dependencies as
they are declared on rubygems.org.

I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
minutes ago, so maybe you could update your patch and add it as an
input.

> +  (description "Code coverage analysis tool for Ruby.  It uses Ruby's
> +built-in Coverage library to gather code coverage data, but makes
> +processing its results much easier by providing a clean API to filter,
> +group, merge, format, and display those results, giving you a complete
> +code coverage suite that can be set up with just a couple lines of
> +code.
> +")

The closing quote and the closing parenthesis should be on the same line
as the period.  The rest looks good to me.

~~ Ricardo