Re: [PATCH] gnu: Add scmutils.

[Federico Beffa]

On Thu, Sep 17, 2015 at 3:03 PM, Ludovic Courtès <address@hidden> wrote:
> Federico Beffa <address@hidden> skribis:
>
>> From 1aacd03326def7b52b8166a80cc18c8e8226aa62 Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <address@hidden>
>> Date: Thu, 13 Aug 2015 18:58:01 +0200
>> Subject: [PATCH] gnu: Add scmutils.
>>
>> * gnu/packages/scheme.scm (scmutils): New variable.
>

[...]

>> +                        (with-directory-excursion "scmutils/scmutils"
>> +                          (copy-files-to-directory '("COPYING" "LICENSE")
>> +                                                   doc #t)
>> +                          (for-each (lambda (f) (delete-file f))
>> +                                    (find-files "." "\\.bin"))
>
>   (for-each delete-file (find-files …))
>
> This phase deletes a bunch of pre-compiled files, which are those Mark
> and you were referring to, IIUC.  Could you move the removal of all the
> pre-compiled files to a ‘snippet’?

The source code and the binary distribution to which Mark was
referring are totally separated and live in different directories. The
code never even enters the directory with the binary code. The files
I'm deleting here are some of the files generated by the compiler, but
not needed at runtime. I delete those and copy everything else from
that directory.

I've added the snippet to delete the directory containing the binary code.

[...]

>> +      (supported-systems '("x86_64-linux" "i686-linux"))
>
> Please add a comment above explaining why this is the case.

Actually I'm not sure if it runs on other platforms. The tarballs are
specific for the Intel x*86* family of processors, but maybe it's just
a restriction on the binary part of the content. I've deleted this
restriction. We'll see if it compiles on hydra.

Thanks for the review,
Fede

0001-gnu-Add-scmutils.patch
Description: Text Data