[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Gracefully handle incompatible locale data
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Gracefully handle incompatible locale data |
Date: |
Tue, 22 Sep 2015 23:22:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ondřej Bílka <address@hidden> skribis:
> On Tue, Sep 22, 2015 at 05:27:55PM +0200, Ludovic Courtès wrote:
>> With libc 2.22 people are starting to realize that libc does not
>> guarantee that it can load locale data built with another libc version,
>> but they learn it the hard way:
>>
>> loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof
>> (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
>>
>> This patch changes such conditions to return EINVAL instead of aborting.
>>
>> WDYT?
>>
> While that assert is quite cryptic I dont see why just returning EINVAL is
> better. How do you distinguish that its wrong locale version versus not
> installed?
The rest of this function already returns EINVAL when something is
fishy. This patch makes the behavior more consistent.
Ludo’.
c
- [PATCH] Gracefully handle incompatible locale data, Ludovic Courtès, 2015/09/22
- Re: [PATCH] Gracefully handle incompatible locale data, Roland McGrath, 2015/09/22
- Re: [PATCH] Gracefully handle incompatible locale data, Ondřej Bílka, 2015/09/22
- Re: [PATCH] Gracefully handle incompatible locale data,
Ludovic Courtès <=
- Re: [PATCH] Gracefully handle incompatible locale data, Ondřej Bílka, 2015/09/22
- Re: [PATCH] Gracefully handle incompatible locale data, Ludovic Courtès, 2015/09/23
- Re: [PATCH] Gracefully handle incompatible locale data, Ondřej Bílka, 2015/09/24
- Re: [PATCH] Gracefully handle incompatible locale data, Ludovic Courtès, 2015/09/24
- Re: [PATCH] Gracefully handle incompatible locale data, Carlos O'Donell, 2015/09/25
- Re: [PATCH] Gracefully handle incompatible locale data, Ludovic Courtès, 2015/09/26
- Re: [PATCH] Gracefully handle incompatible locale data, Carlos O'Donell, 2015/09/29
Re: [PATCH] Gracefully handle incompatible locale data, Andreas Schwab, 2015/09/23
Re: [PATCH] Gracefully handle incompatible locale data, Mark H Weaver, 2015/09/23