Re: [PATCH] gnu: Add cscope

[Ricardo Wurmus]

Hi,

> From 64a74d39d1d58c12806f3991afd5443d8d75bcd5 Mon Sep 17 00:00:00 2001
> From: Jeff Mickey <address@hidden>
> Date: Tue, 29 Sep 2015 18:07:44 -0700
> Subject: [PATCH] gnu: Add cscope

> * gnu/packages/cscope.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

I think this could better be added to the code.scm module rather than
getting its own module.  What do you think?

> +(define-public cscope
> +  (package
> +    (name "cscope")
> +    (version "15.8a")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://downloads.sourceforge.net/";

Please use “mirror://sourceforge...” if possible.

> +                                  name "/" name "-" version ".tar.gz"))
> +              (sha256
> +               (base32 
> "07jdhxvp3dv7acvp0pwsdab1g2ncxjlcf838lj7vxgjs1p26lwzb"))))

This line is too long.  I’m using fci-mode in Emacs to draw a line at
the position of the fill column, so it’s easy to tell if lines are too
long.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags (list (string-append "--with-ncurses=" (assoc-ref 
> %build-inputs "ncurses")))))

This line is also quite a bit too long.  You could easily break this up.

> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "http://cscope.sourceforge.net";)
> +    (synopsis "Tool for browsing source code, with ncurses and editor 
> interfaces")

This synopsis is also a tad too long.

> +    (description "A tool for browsing source code. It has an information
> +database generated for faster searches and later reference, a fuzzy parser
> +that supports C, but is flexible enough to be useful for C++ and Java, and 
> has
> +a command line mode for inclusion in scripts or as a backend to a
> +GUI/frontend.")

Please use two spaces between sentences.  Also, the first sentence
fragment should be a full sentence, such as

   “CScope is a tool for browsing source code...”

not

   “A tool for browsing source code.”

(I should say that to me it’s not obvious what this tool actually does.
Is it something like ctags?)

> +    (license license:bsd-3)))
> +

Okay.

~~ Ricardo