Re: [PATCH] Some dependencies for the planned IPython upgrade.

[Ludovic Courtès]

Skimming on the patches, I only have superficial comments:

Ricardo Wurmus <address@hidden> skribis:

> From 22c5a75aae3fec3bef18f2186ba87d6891439006 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 22 Sep 2015 14:58:16 +0200
> Subject: [PATCH 1/8] gnu: Add python-pexpect.
>
> * gnu/packages/python.scm (python-pexpect, python2-pexpect): New
>   variables.

OK.

> From 3f760ee200cf7353dd51c91507ecab570ff715cd Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 22 Sep 2015 14:59:13 +0200
> Subject: [PATCH 2/8] gnu: Add python-setuptools-scm.
>
> * gnu/packages/python.scm (python-setuptools-scm,
>   python2-setuptools-scm): New variables.

[...]

> +    (synopsis "Manage Python package versions in scm metadata")
> +    (description
> +     "setuptools_scm handles managing your Python package versions in scm
> +metadata instead of declaring them as the version argument or in a scm 
> managed
> +file.")

s/scm/SCM/

In the description, on the first occurrence, write address@hidden
configuration management} (SCM)”.

Otherwise OK.

> From 469a4c3ffdbbf3687413d5ce695bbaa51d1ddf28 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 12:46:24 +0200
> Subject: [PATCH 3/8] gnu: Add python-pytest-runner.
>
> * gnu/packages/python.scm (python-pytest-runner, python2-pytest-runner):
>   New variables.

[...]

> +    (home-page "https://bitbucket.org/pytest-dev/pytest-runner";)
> +    (synopsis "Invoke py.test as distutils command")

“as _a_ distutils command”?

> +    (description
> +     "Setup scripts can use pytest-runner to add setup.py test support for
> +pytest runner.")

What about something like: “This package provides a
@command{pytest-runner} command that @file{setup.py} files can use to
run tests.” ?

> From 09e628d8cf7eeb258f4cb849bf0150f639d13325 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 12:47:16 +0200
> Subject: [PATCH 4/8] gnu: Add python-pathpy.
>
> * gnu/packages/python.scm (python-pathpy, python2-pathpy): New
>   variables.

[...]

> +    (description
> +     "path.py implements path objects as first-class entities, allowing 
> common

@code{path.py}

> From 284d19ae5b604ba0cfa76c1e0343725283ce013c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 12:48:27 +0200
> Subject: [PATCH 5/8] gnu: Add python-pickleshare.
>
> * gnu/packages/python.scm (python-pickleshare, python2-pickleshare): New
>   variables.

OK.

> From e18a12cbfdfe55a7bcfe4542fa9bea3540bbbf29 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 12:50:13 +0200
> Subject: [PATCH 6/8] gnu: Add python-simplegeneric.
>
> * gnu/packages/python.scm (python-simplegeneric, python2-simplegeneric):
>   New variables.

OK.

> From 16790e99b89aa9f63f08ce49d3c79dc8b226cda6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 13:51:03 +0200
> Subject: [PATCH 7/8] gnu: Add python-ipython-genutils.
>
> * gnu/packages/python.scm (python-ipython-genutils,
>   python2-ipython-genutils): New variables.

OK.

> From e6bdd41570a37a4df7d151309b6997365b64164f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 23 Sep 2015 13:51:50 +0200
> Subject: [PATCH 8/8] gnu: Add python-traitlets.
>
> * gnu/packages/python.scm (python-traitlets, python2-traitlets): New
>   variables.

OK.

> +    (description
> +     "Traitlets is a configuration system for Python applications.")

It would be nice if upstream would bother writing a bit more…

Thanks,
Ludo’.