[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 032/151] gnu: Add ghc-hspec-discover.
|
From: |
Paul van der Walt |
|
Subject: |
Re: [PATCH 032/151] gnu: Add ghc-hspec-discover. |
|
Date: |
Tue, 20 Oct 2015 15:30:12 +0200 |
Hi Eric,
I'm starting to fix up your comments.
When i'm done, should i git push -f to the wip-haskell-platform-7.10.2-a
branch, or should i drop that one and create a new one?
On 2015-10-19 at 16:56, quoth address@hidden:
> +(define-public ghc-hspec-discover
> + (package
> + (name "ghc-hspec-discover")
>
> IMHO the name should be "hspec-discover" as this is a standalone program,
> rather than a haskell library.
Changed.
> + (arguments `(#:haddock? #f))
>
> Add a comment here noting how there are no documentation files.
Done.
> + (description "Automatically discover and run Hspec tests.")
>
> Expand this to a full sentence.
Done.
- Re: [PATCH 21/43] gnu: ghc-transformers-compat: New variables., (continued)
Re: [PATCH 01/43] gnu: ghc: Update to 7.10.2., Mathieu Lirzin, 2015/10/15