[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build-system/haskell: CONFIG_SHELL env variable.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] build-system/haskell: CONFIG_SHELL env variable. |
Date: |
Sun, 25 Oct 2015 22:58:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paul van der Walt <address@hidden> skribis:
> For Cabal packages with "build-type: Configure", a configure shell
> script is run to set up build parameters. These scripts need the
> CONFIG_SHELL environment variable to be set to function properly.
>
> * guix/build/haskell-build-system.scm (configure): Set CONFIG_SHELL if
> necessary.
LGTM.
> A previous commit to the haskell-build-system made sure that if
> necessary, the CONFIG_SHELL environment variable is set. That obviates
> the individual patches applied to some packages. Remove them.
>
> * gnu/packages/haskell.scm (ghc-network): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-old-time): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl-image): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl-mixer): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-sdl): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-unix-time): Remove CONFIG_SHELL patch.
> * gnu/packages/haskell.scm (ghc-x11): Remove CONFIG_SHELL patch.
Please use the shorter style, and mention the “syntactical” change:
* gnu/packages/haskell.scm (ghc-network, ghc-old-time,
ghc-sdl-image)[arguments]: Remove 'fix-/bin/sh’ phase.
Apart from this, LGTM.
Thanks!
Ludo’.