Re: [PATCH 14/15] scripts: environment: Add --container option.

[Ludovic Courtès]

"Thompson, David" <address@hidden> skribis:

> Hello, sorry for the delay.
>
> On Tue, Oct 27, 2015 at 6:13 AM, Ludovic Courtès <address@hidden> wrote:

[...]

>> What about automatically mapping $SHELL in the container when it is set?
>
> The issue is that the default command to evaluate is $SHELL or
> "/bin/sh."  You can be almost certain that $SHELL is not going to be
> available in the container.  What to do?  Check if the command is
> 'equal?' to (list (getenv "SHELL")) and make it '("/bin/sh") instead?

What I meant above is to to the equivalent --expose=$SHELL by default
when ‘SHELL’ is set.  Anything wrong with that?

If we did that, we could honor $SHELL even for --container (it’s already
honored in the other case.)

Thanks,
Ludo’.