guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: guile: Add guile-irregex.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: guile: Add guile-irregex.
Date: Fri, 06 Nov 2015 16:15:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Christopher Allan Webber <address@hidden> skribis:

> On a side note, it would really be nice to have a
> r6rs-build-system... starting to result in a lot of similar spaghetti in
> a few of these packages.

Is there really a standard R6 way of doing things?

I agree some factorization would be welcome anyhow!

> From 38edbac8ab42e1518424fd2da4d53ece2c96094c Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Thu, 5 Nov 2015 12:20:03 -0600
> Subject: [PATCH] gnu: guile: Add guile-irregex.
>
> * gnu/packages/guile.scm (guile-irregex): New variable.

[...]

> +     `(#:modules ((guix build utils)
> +                  (ice-9 match)
> +                  ,@%gnu-build-system-modules)

I think (guix build gnu-build-system) is enough on the 3rd line.

> +    (synopsis "S-expression based regular expressions, packaged for Guile")

I’d remove “, packaged for Guile”.

Otherwise LGTM, thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]