guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add owncloud-client.


From: Efraim Flashner
Subject: Re: [PATCH 2/2] gnu: Add owncloud-client.
Date: Sat, 7 Nov 2015 20:35:52 +0200

On Thu, 05 Nov 2015 22:32:21 +0100
address@hidden (Ludovic Courtès) wrote:

> Efraim Flashner <address@hidden> skribis:
> 
> > * gnu/packages/owncloud.scm (owncloud-client): New variable.
> > * gnu-system.am [GNU_SYSTEM_MODULES]: Add it.  
> 
> [...]
> 
> > +       (modify-phases %standard-phases
> > +        (add-after 'unpack 'change-rpath-dirs
> > +          (lambda _
> > +           (substitute* '("src/libsync/CMakeLists.txt"
> > +                          "csync/src/CMakeLists.txt")
> > +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}") ""))
> > +           (substitute* '("src/cmd/CMakeLists.txt"
> > +                          "src/crashreporter/CMakeLists.txt"
> > +                          "src/gui/CMakeLists.txt")
> > +                         (("\\/\\$\\{APPLICATION_EXECUTABLE\\}\\\"") 
> > "\"")))))))  
> 
> Please indent as in other files.  Also, could you add a comment
> explaining what this does?

Intenting fixed. I also added a comment that the default is to save the
libraries in /usr/lib/name/ and we store them in $out/lib/, hence removing
the last piece

> 
> > +    (synopsis "GUI folder synchronization with an ownCloud server")  
> 
> I’d remove “GUI” here (looks weird.)

ok

> 
> > +    (description "The ownCloudSync system lets you always have your latest 
> >  
> 
> … and s/system/GUI/ here.

ok. Also, this package has both the GUI sync client and the cli sync client.
Debian splits the output into two packages, but I'm assuming that wouldn't
actually save that much of the build time.

> 
> Could you send an updated patch?

of course

> 
> Thanks,
> Ludo’.



-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: 0002-gnu-Add-owncloud-client.patch
Description: Text Data

Attachment: pgpERythp8xrR.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]