Re: [PATCH] gnu: Add inklingreader

[Mathieu Lirzin]

Hi Roel,

Roel Janssen <address@hidden> writes:

>>From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <address@hidden>
> Date: Tue, 10 Nov 2015 15:01:33 +0100
> Subject: [PATCH] gnu: Add inklingreader
>
> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
> * gnu/packages/inklingreader.scm: The package description.

Guix has somekind of "template" commit log when adding packages, you
will find multiple examples with

  git log --grep="(GNU_SYSTEM_MODULES): Add it"

When applying it to your package you will obtain this.

--8<---------------cut here---------------start------------->8---
gnu: Add inklingreader.

* gnu/packages/inklingreader.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
--8<---------------cut here---------------end--------------->8---

> ---
>  gnu-system.am                  |  1 +
>  gnu/packages/inklingreader.scm | 65 
> ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 gnu/packages/inklingreader.scm
[...]
> +++ b/gnu/packages/inklingreader.scm
> @@ -0,0 +1,65 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Roel Janssen <address@hidden>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages inklingreader)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gnome)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages libusb)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages texinfo))
> +
> +(define-public inklingreader
> +  (package
> +    (name "inklingreader")
> +    (version "0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-";
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:configure-flags '("--enable-silent-rules")))

this is automatically done, so this flag is not needed.

> +    (inputs
> +     `(("glib" ,glib)
> +       ("cairo" ,cairo)
> +       ("librsvg" ,librsvg)
> +       ("gtk+" ,gtk+)
> +       ("libusb" ,libusb)
> +
> +       ;; Needed to build the package.
> +       ("texinfo" ,texinfo)))

Actually the documentation is not built so I don't think this is needed.
If you want to easily provide the documentation to Guix you will need to
add the Automake variable "info_TEXINFOS" in you Makefile.am file in the
next release, see:

  https://www.gnu.org/software/automake/manual/automake.html#Texinfo

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +
> +    (home-page "http://savannah.gnu.org/projects/inklingreader/";)

I think It would be better to provide

  https://www.gnu.org/software/inklingreader/

> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
> +    (description
> +     "GNU InklingReader is a free software package to support the Wacom 
> Inkling
> +device, including data conversion to various free formats, basic editing
> +features, and an Inkscape plugin.")
> +    (license license:gpl3+)))

Can you send an updated patch?

Thank you very much for your first package!

--
Mathieu Lirzin