[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: guix/scripts/refresh.scm:331:14: warning: non-literal format string.
From: |
Mathieu Lirzin |
Subject: |
Re: guix/scripts/refresh.scm:331:14: warning: non-literal format string. |
Date: |
Mon, 16 Nov 2015 23:12:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Mathieu Lirzin <address@hidden> skribis:
>
>> Here is the snippet of the code producing this warning:
>>
>> (format (current-output-port)
>> (N_ (N_ "A single dependent package: ~2*~{~a~}~%"
>> "Building the following package would ensure
>> ~d \
>> dependent packages are rebuilt; ~*~{~a~^ ~}~%"
>> total-dependents)
>> "Building the following ~d packages would ensure
>> ~d \
>> dependent packages are rebuilt: ~{~a~^ ~}~%"
>> (length rebuilds))
>> (length rebuilds) total-dependents rebuilds)
>>
>> I'm not sure how Gettext plural forms should be used so:
>>
>> - If the code is correct, I think we should provide a comment announcing
>> the warning and explaining why this is OK.
>>
>> - else, how can we fix it?
>
> I believe commit 14649b8 fixes it. It was not obvious at first sight
> how to untangle this, but making it two separate ‘format’ calls does the
> trick.
Thanks for fixing it.
--
Mathieu Lirzin